Unset __PYVENV_LAUNCHER__ on macOS to avoid virtualenv weirdness #28663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exactly how this all works isn't clear, but since the fix in python/cpython#9516 was to simply hide the environment variable from the interpreter it seems reasonably safe. Fixes #27377.
jgraham
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
Ideally I'd like @gsnedders to look at this, but if it works that seems fine.
|
I need this to do anything in WPT and don't want to keep applying it locally, so I'll merge and hope this isn't going to blow up in my face :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exactly how this all works isn't clear, but since the fix in
python/cpython#9516 was to simply hide the
environment variable from the interpreter it seems reasonably safe.
Fixes #27377.