Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tools/third_party/aioquic subtree #23804

Merged
merged 4 commits into from
May 28, 2020
Merged

Fix tools/third_party/aioquic subtree #23804

merged 4 commits into from
May 28, 2020

Conversation

Hexcles
Copy link
Member

@Hexcles Hexcles commented May 27, 2020

I accidentally squash-merged #23075 and screwed up the subtree setup, so
I'm deleting the whole directory and re-introduce the subtree.

Meanwhile, bump a minor release to get the fix for
aiortc/aioquic#89 .

Command:
git subtree add --prefix tools/third_party/aioquic https://github.com/aiortc/aioquic.git 0.8.8 --squash

This needs to be rebase-merged!

Hexcles added 4 commits May 28, 2020 10:49
I accidentally squash-merged #23075 and screwed up the subtree setup, so
I'm deleting the whole directory and re-introduce the subtree in the
next commit.
git-subtree-dir: tools/third_party/aioquic
git-subtree-split: 35342b45d1fdceee8e575869a81d45703d234888
@Hexcles Hexcles force-pushed the fix-quic-subtree branch from ce87e3e to cae0c31 Compare May 28, 2020 14:50
@Hexcles Hexcles merged commit cae0c31 into master May 28, 2020
@Hexcles Hexcles deleted the fix-quic-subtree branch May 28, 2020 14:55
@Hexcles
Copy link
Member Author

Hexcles commented May 28, 2020

FTR, the subtree squash/merge commits could not be rebased, so I:

  1. Created a new branch off of up-to-date master
  2. Ran the subtree command
  3. Switched to master and ran git merge --ff fix-quic-subtree
  4. git push master without waiting for checks to pass (otherwise the branch will become stale again)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants