-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use print() function in both Python 2 and Python 3 #15141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be happy to take the changes to our own code, but we need to discuss the changes to upstream code.
2a9ee02
to
a819285
Compare
The latest CI failures here are #15232. |
@Ms2ger @gsnedders Your reviews please on what remains in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides one comment
Legacy print statements are syntax errors in Python 3 but print() function works as expected in both Python 2 and Python 3.