Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use print() function in both Python 2 and Python 3 #15141

Merged
merged 4 commits into from
Feb 5, 2019

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 29, 2019

Legacy print statements are syntax errors in Python 3 but print() function works as expected in both Python 2 and Python 3.

Ms2ger
Ms2ger previously requested changes Feb 4, 2019
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be happy to take the changes to our own code, but we need to discuss the changes to upstream code.

@gsnedders
Copy link
Member

The latest CI failures here are #15232.

@cclauss
Copy link
Contributor Author

cclauss commented Feb 5, 2019

@Ms2ger @gsnedders Your reviews please on what remains in this PR?

Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides one comment

@Ms2ger Ms2ger dismissed their stale review February 5, 2019 16:01

No longer relevant

@gsnedders gsnedders merged commit 99b96dc into web-platform-tests:master Feb 5, 2019
@cclauss cclauss deleted the print_function branch February 5, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css css-fonts infra pywebsocket third_party wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants