Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a status for unprefixed line-clamp (not supported at all yet) #977

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Apr 26, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Apr 26, 2024
@foolip foolip mentioned this pull request Apr 26, 2024
@foolip foolip requested a review from ddbeck April 29, 2024 08:22
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I do not love the change in mdn/browser-compat-data#22951. It seems to me that spec'd prefixes ought to be their own keys in BCD (i.e., we ought to have both css.properties.-webkit-line-clamp and css.properties.line-clamp), since in a lot of ways it's more like a shorthand than a prefix.

That said, that change is now in BCD, so let's go.

@foolip
Copy link
Collaborator Author

foolip commented Apr 29, 2024

@ddbeck I think that having both line-clamp and -webkit-line-clamp in BCD might be OK, but it does create some additional questions. I'll file a BCD issue for discussion.

@foolip foolip merged commit 4c41cc3 into web-platform-dx:main Apr 29, 2024
3 checks passed
@foolip foolip deleted the dist-line-clamp branch April 29, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants