Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not copy public dir for node target by default #4281

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

9aoy
Copy link
Contributor

@9aoy 9aoy commented Dec 27, 2024

Summary

Do not copy public dir for node target by default. Update publicDir.copyOnBuild default value from true to target !== 'node' as publicDir is not normally used for node target .

Note 🔴 : This modification may cause breaking changes for some users who use publicDir in node target.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 720d00c
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/676e1dd596dc7b0008ef27ce
😎 Deploy Preview https://deploy-preview-4281--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 72 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@9aoy 9aoy requested a review from chenjiahan December 30, 2024 06:10
@chenjiahan chenjiahan changed the title feat!: not copy public dir in node target environment by default fix: do not copy public dir for node target by default Dec 30, 2024
@chenjiahan chenjiahan merged commit 0f1504d into main Dec 30, 2024
12 checks passed
@chenjiahan chenjiahan deleted the feat/node-copy-on-build branch December 30, 2024 09:26
@chenjiahan chenjiahan mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants