Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set default command for createCompiler() #4254

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Conversation

chenjiahan
Copy link
Member

Summary

When calling the rsbuild.createCompiler() method, if context.command does not exist, we should assign a default value based on process.env.NODE_ENV to ensure dev and build hooks work as expected.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 3aa6750
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/676a444405b2bd0008816541
😎 Deploy Preview https://deploy-preview-4254--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 70 (🔴 down 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 7a45ffd into main Dec 24, 2024
10 checks passed
@chenjiahan chenjiahan deleted the create_compiler_1224 branch December 24, 2024 06:01
@chenjiahan chenjiahan mentioned this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant