Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin/assets-retry): make loadScript safer #3860

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix(plugin/assets-retry): make loadScript safer #3860

merged 1 commit into from
Oct 29, 2024

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Oct 29, 2024 •
edited
Loading

Summary

😂 loadScript in webpack runtime is for all the script, I'd better to scope it for safer

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Oct 29, 2024 •
edited
Loading

✅ Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 85bd85a
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6720dd3fa469b600080365b3
😎 Deploy Preview https://deploy-preview-3860--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 73 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter SoonIter changed the title fix(plugin/assets-retry): wrong loadScript fix(plugin/assets-retry): make loadScript safer Oct 29, 2024
@SoonIter SoonIter marked this pull request as ready for review October 29, 2024 13:27
@SoonIter SoonIter requested a review from chenjiahan October 29, 2024 13:28
chenjiahan
chenjiahan approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@chenjiahan chenjiahan merged commit 6f455f2 into main Oct 29, 2024
12 checks passed
@chenjiahan chenjiahan deleted the safe branch October 29, 2024 14:08
@chenjiahan chenjiahan mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees
No one assigned
Labels
release: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SoonIter @chenjiahan