fix(plugin-less): lessLoaderOptions.lessOptions.plugins has lose it's prototype. #3815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
chenjiahan
reviewed
Oct 24, 2024
packages/plugin-less/src/index.ts
Outdated
| @@ -75,7 +75,11 @@ const getLessLoaderOptions = ( | |||
| ): LessLoaderOptions => { | |||
| const getLessOptions = () => { | |||
| if (defaults.lessOptions && userOptions.lessOptions) { | |||
| return deepmerge(defaults.lessOptions, userOptions.lessOptions); | |||
| return deepmerge(defaults.lessOptions, userOptions.lessOptions, { | |||
| isMergeableObject: (obj) => | |||
There was a problem hiding this comment.
Can we use the internal isPlainObject helper here?
The same as
There was a problem hiding this comment.
yeah, of course.
Sang-Sang33
force-pushed
the
fix-plugin-less-plugins
branch
2 times, most recently
from
cac000a to
6c5b370
Compare
Sang-Sang33
changed the title
Sang-Sang33
force-pushed
the
fix-plugin-less-plugins
branch
2 times, most recently
from
cfedf4f to
930b216
Compare
Sang-Sang33
force-pushed
the
fix-plugin-less-plugins
branch
from
52e0d8b to
7be4917
Compare
|
I will merge this PR and fix the snapshot, thank you |
This was referenced Oct 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix the
deepmergeto judge whether is an plain object.Related Links
#3810
Checklist