Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): ensure that keep the original URL #3674

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

Cheese-Yu
Copy link
Contributor

@Cheese-Yu Cheese-Yu commented Oct 10, 2024

Summary

When customize html.publicPath with url and using performance.prefetch changed the parameters what I set.

Eg:
config is: publicPath: 'https://{{CDN_HOST}}/{{CDN_PATH_PREFIX}}',
output is: <link href="https://{{cdn_host}}/%7B%7BCDN_PATH_PREFIX%7D%7D/static/js/async/318.1e5b1319.js" rel="prefetch">

Because urlJoin use new URL changed url parameter.

The usage scenario is as follows:
Dynamically set CDN links when accessed by different environments.

Related Links

reproduce: https://github.com/Cheese-Yu/rsbuid-prefetch-mini-repo

Checklist

  • [ x ] Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 0db5f24
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/6707d7b2b086f20009fbb42f
😎 Deploy Preview https://deploy-preview-3674--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 83 (🟢 up 9 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@chenjiahan chenjiahan changed the title fix(core): ensure that keep url original fix(core): ensure that keep the original URL Oct 10, 2024
@chenjiahan chenjiahan enabled auto-merge (squash) October 10, 2024 13:34
@chenjiahan chenjiahan merged commit 38a9a56 into web-infra-dev:main Oct 10, 2024
10 checks passed
@chenjiahan chenjiahan mentioned this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants