Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: no need to init Rspack config before preview #3644

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

chenjiahan
Copy link
Member

Summary

No need to init the Rspack config before rsbuild preview.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 933a7c0
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67034582f7187300087c8800
😎 Deploy Preview https://deploy-preview-3644--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 72 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit f75b1e5 into main Oct 7, 2024
10 checks passed
@chenjiahan chenjiahan deleted the preview_init_1007 branch October 7, 2024 02:29
@chenjiahan chenjiahan mentioned this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant