fix(plugin-webpack-swc): swcMinimizerPlugin sourceMap config #3550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
easy1090
requested review from
chenjiahan
and removed request for
chenjiahan
chenjiahan
reviewed
Sep 25, 2024
| @@ -9,6 +9,7 @@ import color from 'picocolors'; | |||
| import { minify, minifyCss } from './binding'; | |||
| import { JS_REGEX } from './constants'; | |||
| import type { CssMinifyOptions, JsMinifyOptions, Output } from './types'; | |||
| import { isUndefined } from 'lodash'; | |||
There was a problem hiding this comment.
We want to avoid using lodash, how about foo === undefined?
chenjiahan
reviewed
Sep 25, 2024
| @@ -35,15 +36,19 @@ export class SwcMinimizerPlugin { | |||
|
|
|||
| private name = 'swc-minimizer-plugin'; | |||
|
|
|||
| private rsbuildConfigSourceMap: NormalizedEnvironmentConfig['output']['sourceMap']; | |||
There was a problem hiding this comment.
rsbuildConfigSourceMap -> rsbuildSourceMapConfig
easy1090
force-pushed
the
fix/swc-plugin-sourcemap-config
branch
2 times, most recently
from
8277331 to
9aa70ee
Compare
…t to the swcMinimizerPlugin fix(plugin-webpack-swc): the rsbuildConfig's sourcemap should transmit to the swcMinimizerPlugin fix(plugin-webpack-swc): the rsbuildConfig's sourcemap should transmit to the swcMinimizerPlugin
easy1090
force-pushed
the
fix/swc-plugin-sourcemap-config
branch
from
9aa70ee to
37cb521
Compare
chenjiahan
approved these changes
Sep 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix(plugin-webpack-swc): the rsbuildConfig's sourcemap should transmit to the swcMinimizerPlugin
Related Links
Checklist