-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade react-router-dom to avoid issues #4566
Conversation
🦋 Changeset detectedLatest commit: f33d433 The changes in this PR will be included in the next version bump. This PR includes changesets to release 253 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4566 +/- ##
==========================================
- Coverage 57.59% 53.74% -3.86%
==========================================
Files 672 655 -17
Lines 17794 17966 +172
Branches 3876 4142 +266
==========================================
- Hits 10249 9656 -593
- Misses 6934 7652 +718
- Partials 611 658 +47 ☔ View full report in Codecov by Sentry. |
Summary
react-router-dom has some issues in react17:
🤖 Generated by Copilot at ac9fafb
This pull request fixes a compatibility issue between
@modern-js/utils
and@remix-run/router
by updating therenderNestedRoute
function and thereact-router-dom
dependency. It also adds a changeset file to document the patch.Details
🤖 Generated by Copilot at ac9fafb
@modern-js/utils
package (link)react-router-dom
dependency version inpackage.json
(link)renderNestedRoute
function innestedRoutes.tsx
(link, link)Related Issue
Checklist
pnpm run change
.