Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

Replacing custom testing helpers with testify, where possible #955

Merged
merged 4 commits into from
Jun 23, 2015

Conversation

paulbellamy
Copy link
Contributor

Closes #358

@rade
Copy link
Member

rade commented Jun 17, 2015

@inercia @awh would appreciate you taking a look at this.

I have suggested to @paulbellamy that we should file PRs against testify for adding the two helpers we are currently left with.

@inercia
Copy link
Contributor

inercia commented Jun 17, 2015

Looks good to me. It's great to use someone's else library for this...

@inercia
Copy link
Contributor

inercia commented Jun 18, 2015

Regarding testify missing the stacktraces, it would be great if we could be more general and call any user-provided callback when Fatalf is invoked. This callback could be a function for dumping the stack trace, but it could also be a function for dumping all the goroutines stacks, stop the debugger, etc...

paulbellamy added a commit that referenced this pull request Jun 23, 2015
Replacing custom testing helpers with testify, where possible
@paulbellamy paulbellamy merged commit 0a28721 into weaveworks:master Jun 23, 2015
@paulbellamy paulbellamy deleted the testing branch June 23, 2015 11:21
@rade rade modified the milestone: 1.1.0 Jul 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants