Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

Make address argument to weave dns-{add|remove} optional #1379

Merged
merged 3 commits into from
Sep 4, 2015
Merged

Make address argument to weave dns-{add|remove} optional #1379

merged 3 commits into from
Sep 4, 2015

Conversation

awh
Copy link
Contributor

@awh awh commented Sep 3, 2015

Fixes #1369.

@awh
Copy link
Contributor Author

awh commented Sep 3, 2015

We should explain all the various dns-add permutations. Not necessarily individually, but it must be clear what dns-add is capable of.

Also, the weave dns-remove example needs updating.

Comments addressed.

@awh awh mentioned this pull request Sep 4, 2015
Merged
bboreham added a commit that referenced this pull request Sep 4, 2015
@bboreham
Merge pull request #1379 from awh/issues/1369-weave-dns-add-remove-op…
145a527 
…tional-ip

LGTM.  Fixes #1369
@bboreham bboreham merged commit 145a527 into weaveworks:master Sep 4, 2015
@rade rade modified the milestone: 1.1.0 Sep 4, 2015
@awh awh deleted the issues/1369-weave-dns-add-remove-optional-ip branch October 7, 2015 17:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@bboreham bboreham

Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@awh @rade @bboreham