[proxy] add --rewrite-inspect flag

[paulbellamy]

To return the weave ip/mac for docker inspect calls.

Fixes #117, and #1199 (possibly? Anything else outstanding for that?)

[errordeveloper]

I will test this with Kubernetes once again now.

[errordeveloper]

I confirm this is working perfectly well with Kubernetes.

[paulbellamy]

Note, docker NetworkSettings includes:

"NetworkSettings": {
    "Bridge": "",
    "Gateway": "",
    "IPAddress": "",
    "IPPrefixLen": 0,
    "MacAddress": "",
    "PortMapping": null,
    "Ports": null
},

This only overwrites the IPAddress, IPPrefixLen, and MacAddress, but not Gateway.

[bboreham]

Gateway seems to point to the docker bridge IP. I don't think we should leave that in place.

[bboreham]

Changes look good; we are still leaving gateway in the NetworkSettings - do we want that?

[paulbellamy]

Could replace gateway with the IP of the weave router... But I'm not sure how correct that is.

[bboreham]

This gateway refers to the route that the container has to the rest of the world, so given that we don't add such a route for ethwe I don't think we should claim a fake one.

I'm not so sure now that leaving it is wrong. That route and gateway still exists. It just isn't associated with the IP or MAC that we are now returning.

[paulbellamy]

If we are returning an IP/MAC for an interface with no gateway, it probably makes most sense not to return a gateway.

[rade]

Is d7d8b86 also fixing #1371?

[bboreham]

No, it's avoiding making #1371 worse for this specific data. Some of the code will be re-usable when we fix #1371 fully.

[rade]

Hmm. It feels odd to do things completely differently here.

[bboreham]

It seems much more likely that we will spoil someone's day by disrupting what is returned by docker inspect when Docker change it, than the return values from create, start, restart, etc. Borne out by the fact that only one person managed to trip over this in the real world so far.

[rade]

@paulbellamy anything left to do here?

[paulbellamy]

I believe all of the comments have been addressed, so if the docs look good, then it should be ready to go.

[bboreham]

LGTM