This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Add a min docker version check #1298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bailing out early is better UX Properly fixes weaveworks#1297
|
This checks the Docker client version. It's the server version that matters. See #576 (comment) for the gory details (and why we haven't done this). Though perhaps mandating client >=1.3.1 is the least worst option here. |
| # guard against https://github.com/docker/docker/issues/8632 | ||
| if [ "$DOCKER_VERSION" = "1.3.0" ] ; then | ||
| echo "You are running Docker version $DOCKER_VERSION, which contains a bug that prevents weave from working properly. Please upgrade." >&2 | ||
| FLAG=$(awk 'BEGIN { print ("$DOCKER_VERSION" < "$MIN_DOCKER_VERSION") ? "1" : "0" }') |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
superseded by #1326. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bailing out early is better UX
Properly fixes #1297