Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

[proxy] add --rewrite-inspect flag #1222

Closed
wants to merge 2 commits into from
Closed

Conversation

paulbellamy
Copy link
Contributor

To return the weave ip/mac for docker inspect calls.

Blocked on a pr to go-dockerclient being merged: fsouza/go-dockerclient#336

@errordeveloper, Could you see if this works for you?

Possibly, fixes #1199?

@paulbellamy paulbellamy force-pushed the 1199-proxy-kubernetes branch from 2f2b79c to cb86039 Compare August 4, 2015 14:07
@paulbellamy paulbellamy closed this Aug 4, 2015
@paulbellamy
Copy link
Contributor Author

Closed while being tried out. Needs testing for the USR2 change, if it works.

@errordeveloper
Copy link
Contributor

Yeah, looks like it works, just testing from scratch now. Will update.

@rade rade modified the milestone: 1.1.0 Aug 5, 2015
@errordeveloper
Copy link
Contributor

Ok, so just for the record, this appears to work, however I am seeing a strange issue which looks like only some /w/w processes get SIGUSR2. I am not quite sure, but due to the signal having to go via Docker and my overcomited VMs might struggle and hit some edge case where Docker does't end-up sending those signals. To confirm, I will have to trace whether Docker calls signal() or what not, as well as read the code. According to the logs, it's supposed to, but I am not entirely convinced with that being a guarantee. I've checked with David, and he say that signals cannot just get dropped, although they may get blocked.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make proxy work with kubernetes
3 participants