Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

Correctly stop the test gossip router to prevent complaints of data races in subsequent tests. #1183

Merged
merged 1 commit into from
Jul 17, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions nameserver/nameserver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,11 @@ func makeNetwork(size int) ([]*Nameserver, *gossip.TestRouter) {
return nameservers, gossipRouter
}

func stopNetwork(nameservers []*Nameserver) {
func stopNetwork(nameservers []*Nameserver, grouter *gossip.TestRouter) {
for _, nameserver := range nameservers {
nameserver.Stop()
}
grouter.Stop()
}

type pair struct {
Expand Down Expand Up @@ -74,7 +75,7 @@ func TestNameservers(t *testing.T) {

lookupTimeout := 20 // ms
nameservers, grouter := makeNetwork(50)
defer stopNetwork(nameservers)
defer stopNetwork(nameservers, grouter)
nameserversByName := map[router.PeerName]*Nameserver{}
for _, n := range nameservers {
nameserversByName[n.ourName] = n
Expand Down
6 changes: 6 additions & 0 deletions testing/gossip/mocks.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ func NewTestRouter(loss float32) *TestRouter {
return &TestRouter{make(map[router.PeerName]chan interface{}, 100), loss}
}

func (grouter *TestRouter) Stop() {
for peer := range grouter.gossipChans {
grouter.RemovePeer(peer)
}
}

func (grouter *TestRouter) gossipBroadcast(sender router.PeerName, update router.GossipData) error {
for _, gossipChan := range grouter.gossipChans {
select {
Expand Down