This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Make Gossip DNS reject gossip messages if clockskew > tombstoneTimeout / 2 #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return nil, nil, err | ||
| } | ||
|
|
||
| if err := entries.check(); err != nil { | ||
| if gossip.Timestamp < now()-int64(gossipWindow/time.Second) { | ||
| return nil, nil, fmt.Errorf("Refusing old gossip message: %d", gossip.Timestamp) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
tomwilkie
force-pushed
the
1156-gossip-timestamp
branch
from
9980ab7 to
5398fb0
Compare
| return nil, nil, err | ||
| } | ||
|
|
||
| if err := entries.check(); err != nil { | ||
| if delta := gossip.Timestamp - now(); delta > gossipWindow || delta < -gossipWindow { | ||
| return nil, nil, fmt.Errorf("Refusing old gossip message (delta %d): %d", delta, gossip.Timestamp) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Apart from one nit this LOKTM |
tomwilkie
force-pushed
the
1156-gossip-timestamp
branch
from
5398fb0 to
9e0702d
Compare
|
Test failure is flakey TestNameservers so can safely be ignored. I'm looking into it. |
tomwilkie
force-pushed
the
1156-gossip-timestamp
branch
from
9e0702d to
4e29dba
Compare
bboreham
added a commit
that referenced
this pull request
Jul 20, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1156
5mins max clock skew seems too small to me; I suggest we make it bigger (and therefore make the DNS tombstone timeout larger).