This repository was archived by the owner on Jun 20, 2024. It is now read-only.
More helpful error message when --ip-alloc-range mismatched #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| prefixLen := 32 | ||
| for size := r.Size(); size > 1; size = size / 2 { | ||
| if size%2 != 0 { // Size not a power of two; cannot be expressed as a CIDR. | ||
| return fmt.Sprintf("[Range cannot be expressed in CIDR format] %s", r) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
bboreham
force-pushed
the
1128-iprange-error
branch
from
16ab956 to
1f4b943
Compare
Fair enough, but that means you really ought to change the error message and error name in the |
bboreham
force-pushed
the
1128-iprange-error
branch
from
dbcfdcb to
a00671d
Compare
bboreham
force-pushed
the
1128-iprange-error
branch
from
a00671d to
2dbf838
Compare
rade
added a commit
that referenced
this pull request
Jul 17, 2015
More helpful error message when --ip-alloc-range mismatched Closes #1128.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1128
I did an additional check at the
Allocatorlevel rather than modifying the check insideRing, to keep the latter unaware of whyMergehas been called.