Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

Copy dns requests and give them a fresh id when doing recursive queries. #1142

Merged
merged 2 commits into from
Jul 15, 2015
Merged

Copy dns requests and give them a fresh id when doing recursive queries. #1142

merged 2 commits into from
Jul 15, 2015

Conversation

tomwilkie
Copy link
Contributor

Fixes #1113

@tomwilkie
Copy link
Contributor Author

@inercia would you mind reviewing please?

inercia
inercia reviewed Jul 15, 2015
View reviewed changes
nameserver/dns.go
@@ -227,7 +227,9 @@ func (d *DNSServer) handleRecursive(client *dns.Client, defaultMaxResponseSize i
}

for _, server := range d.upstream.Servers {
response, _, err := client.Exchange(req, fmt.Sprintf("%s:%s", server, d.upstream.Port))
reqCopy := *req

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@inercia
Copy link
Contributor

inercia commented Jul 15, 2015

LGTM. Will merge once the CI tests pass...

inercia added a commit that referenced this pull request Jul 15, 2015
@inercia
Merge pull request #1142 from weaveworks/1113-recursive-dns
7e34ec6 
Closes #1113
@inercia inercia merged commit 7e34ec6 into master Jul 15, 2015
@rade rade deleted the 1113-recursive-dns branch July 15, 2015 12:25
@rade rade modified the milestone: 1.1.0 Jul 21, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@inercia inercia

Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tomwilkie @inercia @rade