This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Check addresses supplied by users for conflict with existing routes #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
force-pushed
the
437-check-address
branch
from
7b55f4e to
7762771
Compare
For a network, as used by IPAM, we care if *any* address in the range could possibly conflict with an existing address routed by the host. When given a single address, we only care if *that specific address* conflicts with an existing route.
…ith an existing route
bboreham
force-pushed
the
437-check-address
branch
from
7762771 to
9109969
Compare
| } | ||
| for _, route := range routes { | ||
| if route.Dst != nil && route.Dst.Contains(addr) { | ||
| return fmt.Errorf("Address %s would overlap with existing route %s", addr, route.Dst) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Where does the warning pop up when using the proxy? In the CLI? The proxy logs? |
Nowhere, it seems. |
|
#1056 created for proxy issue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #437, #480.
Issues a warning but carries on.
Note that we are still not checking ranges passed to IPAM; I'm still considering whether that is a good idea.