Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

pass common weave launch parameters to all components #1043

Closed
bboreham opened this issue Jun 29, 2015 · 2 comments
Closed

pass common weave launch parameters to all components #1043

bboreham opened this issue Jun 29, 2015 · 2 comments
Assignees
@rade
Labels
feature
Milestone
1.1.0

Comments

@bboreham
Copy link
Contributor

Following #1009, three containers are started with one command. I found it a bit surprising that extra arguments only get passed to the router, not to weavedns or proxy.

Currently, -debug seems to be the only one that would require this treatment, though fixing #329 would introduce another flag that needs to go to weavedns.
@rade
Copy link
Member

rade commented Jun 29, 2015

it's not clear what you mean by extra here. We option parser complains about undefined parameters, which is reasonable. So we cannot just pass all parameters to all three containers.

We can make an exception for common parameters.

@rade rade added the feature label Jun 29, 2015
@rade rade changed the title weave launch only passes extra command-line flags to the router pass common weave launch parameters to all components Jun 29, 2015
@rade rade modified the milestone: current Jul 2, 2015
@rade
Copy link
Member

rade commented Jul 3, 2015

Let's tackle this post #329, since log levels is the only common parameter.

rade added a commit that referenced this issue Jul 4, 2015
@rade
pass common launch args to all three components
d064106 
ATM that's just --loglevel=...

Closes #1043.
@rade rade mentioned this issue Jul 4, 2015
Merged
@rade rade self-assigned this Jul 4, 2015
@rade rade modified the milestones: current, 1.1.0 Jul 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rade rade

Labels
feature
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@rade @bboreham