Skip to content
This repository was archived by the owner on Jun 20, 2024. It is now read-only.

weave env|config #1014

Closed
rade opened this issue Jun 25, 2015 · 0 comments
Closed

weave env|config #1014

rade opened this issue Jun 25, 2015 · 0 comments
Labels
[component/proxy] feature
Milestone
1.1.0

Comments

@rade
Copy link
Member

rade commented Jun 25, 2015

Following #962, it feels a bit strange to mention the proxy in the step following launch. I suggest we either rename weave proxy-[env|config] to weave env|config, or just add the latter. One thing this hinges on is error behaviour. IMO it is reasonable for weave proxy-[env|config] to fail, as it currently does, when the proxy isn't running. But that's perhaps not so desirable for weave env|config, where returning nothing might make more sense?
@rade rade added the feature label Jun 25, 2015
@rade rade mentioned this issue Jun 25, 2015
Closed
@rade rade modified the milestone: current Jul 2, 2015
@paulbellamy paulbellamy mentioned this issue Jul 6, 2015
Merged
@rade rade closed this as completed in #1080 Jul 6, 2015
rade added a commit that referenced this issue Jul 6, 2015
@rade
Merge pull request #1080 from weaveworks/1014-weave-env
cf7fff3 
rename proxy-(env|config) to (env|config)

Closes #1014.
@rade rade modified the milestones: current, 1.1.0 Jul 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
[component/proxy] feature
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@rade