This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
tracer: update gobpf and set maxactive #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blixtra
reviewed
Apr 5, 2017
pkg/tracer/tracer.go
Outdated
| @@ -16,6 +16,12 @@ type Tracer struct { | |||
| stopChan chan struct{} | |||
| } | |||
|
|
|||
| // maxActive configures the maximum number of instances of the probed functions | |||
| // that can be handled imultaneously. | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
alban
suggested changes
Apr 5, 2017
There was a problem hiding this comment.
The commit message could mention that we need to include the changes from
iovisor/gobpf#39
Needed to get the changes in iovisor/gobpf#39
Use maxactive=128.
alban
added a commit
to kinvolk-archives/scope
that referenced
this pull request
Apr 6, 2017
It will help to get missing kretprobe events during the ebpf tracker initialization: - weaveworks/tcptracer-bpf#36 - iovisor/gobpf#39 On Linux >= 4.12 (unreleased), accept events should be better tracked too. The new gobpf vendoring also includes other small fixes such as error handling.
alban
added a commit
to kinvolk-archives/scope
that referenced
this pull request
Apr 6, 2017
It will help to get missing kretprobe events during the ebpf tracker initialization and missing connect & accept events, specially visible on single-cores: - weaveworks/tcptracer-bpf#36 - iovisor/gobpf#39 It makes use of a Linux patch that should be in Linux >= 4.12 (unreleased yet): iovisor/bcc#1072 (comment) It falls back gracefully on current/older Linux kernels. The new gobpf vendoring also includes other small fixes such as error handling.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gobpf gained support for configuring the 'maxactive' attribute for kretprobes.
This requires kernel support, which is not merged yet: https://lkml.org/lkml/2017/4/3/225
If the kernel doesn't have support for it, we'll fall back to the default, so things shouldn't change for that case.
Fixes #34