move docker labels into their own table of the details panel #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to work, so LGTM from me. Shame we have to hard code it in the UI/API like that. |
|
|
The flipside of "hardcoding" it is that the UI understands some of the semantics of what it's rendering, which is good. |
paulbellamy
force-pushed
the
docker-labels
branch
from
9fa1d2d to
0a292f5
Compare
paulbellamy
added a commit
that referenced
this pull request
Feb 3, 2016
move docker labels into their own table of the details panel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #802
review @tomwilkie, and @davkal, please