fix (probe): skip publishing empty reports #3774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the probe is configured with `spy.interval` greater than `publish.interval`, the report to be published can be completely blank. In that case, skip publishing it so the next time we do have some data the time-window is correct.
bboreham
force-pushed
the
probe-skip-empty-reports
branch
from
d084622 to
951d7a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the probe is configured with
spy.intervalgreater thanpublish.interval, the report to be published can be completely blank.In that case, skip publishing it so the next time we do have some data the time-window is correct.