Simplify some renderers #3747
Simplify some renderers #3747
Conversation
Crunch a Map and Reduce into a single Renderer that has the same function.
The second half of the render added all the same nodes, except for those with no Docker image information, so we could show a figure for those filtered out on that basis. This just isn't worth the effort.
| ContainerWithImageNameRenderer, | ||
| ), | ||
| // Grab *all* the hostnames, so we can count the number which were empty | ||
| // for accurate stats. |
There was a problem hiding this comment.
Where would these stats be displayed?
There was a problem hiding this comment.
Bottom-left of the screen, like "21 nodes (119 filtered)"
There was a problem hiding this comment.
Ok cool. That information's been misleading and incorrect at times for container topologies so I'm ok seeing it removed.
Looking at the UI code, it seems it's already robust enough to not display filtered nodes count if it's not provided so probably nothing will need to be updated there 👍
| // Grab *all* the hostnames, so we can count the number which were empty | ||
| // for accurate stats. | ||
| MakeMap( | ||
| MapToEmpty, |
There was a problem hiding this comment.
After removing it from here, this method is not used anymore so feel free to remove it from container.go.
| // ContainerImageRenderer is a Renderer which produces a renderable container | ||
| // image graph by merging the container graph and the container image topology. | ||
| // ContainerImageRenderer produces a graph where each node is a container image | ||
| // with the original containers as children |
|
I am yak-shaving towards a significant performance improvement; this one piece doesn't do much but it helps to simplify the problem. |
ContainerImageRenderer: Crunch aMapandReduceinto a singleRendererthat has the same function.ContainerHostnameRenderer: The second half of the render added all the same nodes, except forthose with no Docker image information, so we could show a figure for those filtered out on that basis. This just isn't worth the effort.
And remove unused parameterisation of
containerWithImageNameRenderer