Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: allow user to disable plugins via command-line flag #3703

Merged
merged 1 commit into from
Oct 8, 2019
Merged

feature: allow user to disable plugins via command-line flag #3703

merged 1 commit into from
Oct 8, 2019

Conversation

bboreham
Copy link
Collaborator

@bboreham bboreham commented Oct 6, 2019

I wanted to do this to get rid of debug-level log messages every few seconds, but it might also be desirable to reduce attack surface.

fbarl
fbarl approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

qiell
qiell approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@qiell qiell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiell qiell merged commit 4bafaa1 into master Oct 8, 2019
@qiell qiell deleted the allow-disable-plugins branch October 8, 2019 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbarl fbarl fbarl approved these changes

@qiell qiell qiell approved these changes

@satyamz satyamz Awaiting requested review from satyamz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bboreham @fbarl @qiell