Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket tracing spans #3682

Merged
merged 4 commits into from
Sep 17, 2019
Merged

Websocket tracing spans #3682

merged 4 commits into from
Sep 17, 2019

Conversation

bboreham
Copy link
Collaborator

Since the http call lasts forever, the spans for it don't appear.
Instead, start a new root span every time round the loop (which is typically every 5 seconds).

For the multitenant case it's useful to have a tag with the userid.

@bboreham bboreham requested a review from qiell as a code owner September 15, 2019 20:55
@qiell qiell requested a review from fbarl September 16, 2019 07:55
Copy link
Contributor

@fbarl fbarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! 👌

Up to you whether you want to address my small comments.

app/api_topology.go Outdated Show resolved Hide resolved
app/api_topology.go Outdated Show resolved Hide resolved
@bboreham bboreham requested a review from satyamz as a code owner September 16, 2019 11:04
@fbarl
Copy link
Contributor

fbarl commented Sep 16, 2019

Thanks for the changes, feel free to merge now!

@bboreham bboreham merged commit 938d594 into master Sep 17, 2019
@bboreham bboreham deleted the websocket-tracing branch September 17, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants