Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update some javascript dependencies #3664

Merged
merged 4 commits into from
Aug 30, 2019
Merged

update some javascript dependencies #3664

merged 4 commits into from
Aug 30, 2019

Conversation

dholbach
Copy link
Contributor

No description provided.

@dholbach dholbach self-assigned this Aug 20, 2019
@dholbach dholbach marked this pull request as ready for review August 20, 2019 14:26
@dholbach dholbach requested a review from qiell as a code owner August 20, 2019 14:26
@dholbach dholbach requested review from fbarl and foot August 20, 2019 14:28
@qiell
Copy link
Contributor

qiell commented Aug 21, 2019

Screenshot from 2019-08-21 16-55-58

Not able to drag the components in Graph Mode, getting above error in Console of UI.

@qiell
Copy link
Contributor

qiell commented Aug 21, 2019

It occurs when multiple versions of d3-selection are listed in yarn.lock https://stackoverflow.com/a/53478226/6948058
d3/d3-selection#185 (comment)

cc: @fbarl

@dholbach
Copy link
Contributor Author

It occurs when multiple versions of d3-selection are listed in yarn.lock https://stackoverflow.com/a/53478226/6948058
d3/d3-selection#185 (comment)

Wow, nice catch!

Reverting d3-selection to 1.3.2 fixes the issue.

@qiell
Copy link
Contributor

qiell commented Aug 21, 2019 •
edited
Loading

We can fix this by adding the resolutions section in package.json file. I got this solution from d3/d3-selection#185 (comment)

+  "resolutions": {
+    "d3-selection": "1.3.2",
+    "d3-selection": "1.4.0"
+  },

"d3-selection": "1.3.2" is required in resolutions because it is used in ui-components

Removed the yarn.lock file and then ran yarn install.
I tried it on my local setup and it works fine.

@dholbach
Copy link
Contributor Author

Maybe we can merge as is and then update the rest in another PR?

@qiell
Copy link
Contributor

qiell commented Aug 30, 2019

Sure @dholbach

qiell
qiell approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@qiell qiell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dholbach dholbach merged commit 445b406 into master Aug 30, 2019
@dholbach dholbach deleted the update-js-libs branch August 30, 2019 13:01
@foot foot mentioned this pull request Sep 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiell qiell qiell approved these changes

@fbarl fbarl Awaiting requested review from fbarl

@foot foot Awaiting requested review from foot

Assignees

@dholbach dholbach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dholbach @qiell