Update google/gopacket library #3606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I retried the integration-tests, but looks like they're broken for some reason. |
|
@bboreham Was there an issue manifestation in Scope that motivated this PR? |
Scope's build is still using an older Go, but on my dev machine with Go 1.12 this change is needed to compile. |
To pick up a fix google/gopacket#589 for Go 1.12
bboreham
force-pushed
the
update-gopacket
branch
from
bc9de99 to
07d3dfd
Compare
The previous code seems to be relying on a 64-bit to 32-bit conversion working in a certain way; when gopacket was changed to cast the value explicitly it starts returning immeditely from pcap.
|
I found the unlikely reason for the test failure. |
satyamz
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To pick up a fix google/gopacket#589 for Go 1.12