Expose probe metrics to Prometheus #3600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarl
reviewed
May 15, 2019
There was a problem hiding this comment.
Nice one! 👍
Two more comments:
- count of conntrack errors from instrument probes with some prometheus metrics #2318 - do we do that one already?
- It would be nice to update the docs somewhere to tell users they can change the flag to control get the exposed Prometheus metrics
| cfg := &metrics.Config{ | ||
| ServiceName: "scope-probe", | ||
| TimerGranularity: time.Second, | ||
| FilterDefault: true, // Don't filter metrics by default |
There was a problem hiding this comment.
I guess the comment here is a bit confusing as it reads as a negation of the code :)
| metrics.MeasureSinceWithLabels([]string{"duration", "seconds"}, t, []metrics.Label{ | ||
| {Name: "operation", Value: "ticker"}, | ||
| {Name: "module", Value: ticker.Name()}, | ||
| }) |
There was a problem hiding this comment.
Maybe, but I'm just exposing what we already had. I can change "Fixes" to "fixes part of".
There was a problem hiding this comment.
I can change "Fixes" to "fixes part of".
Yeah, either that or adding the cases if it's a small enough change - your call!
Signed-off-by: Bryan Boreham <[email protected]>
We are already timing all report, tag and tick operations. If Prometheus is in use, expose those metrics that way. Adjust metrics naming to fit with Prometheus norms. The previous way these metrics were exposed was via SIGUSR1, and we can only have one "sink", so make it either-or. Signed-off-by: Bryan Boreham <[email protected]>
bboreham
force-pushed
the
expose-probe-metrics
branch
from
b547fff to
5e57b0d
Compare
|
I added a few more metrics so I believe this can close #2318 now |
fbarl
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2318
We are already timing all report, tag and tick operations via the armon/go-metrics library, added in #658. If Prometheus is in use, expose those metrics that way.
Adjust metrics naming to fit with Prometheus norms.
The previous way these metrics were exposed was via SIGUSR1, and we can only have one "sink", so make it either-or.
Example output: