Fix bug 56+ chrome can't prevent default wheel events. #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug where 56+ chrome can't prevent default wheel events. Fixes weaveworks#3592
|
Thank you for your PR @leavest - the code change is nice and concise and I'd give it a pass 👌, but I can't upgrade to Chrome 0.73 on my machine to test the fix so I'd ask someone else to take a look at the behavior. p.s. Everything behaves well on my Chrome 0.72, both on this branch and on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use a new method to bind wheel event.
https://www.chromestatus.com/features/6662647093133312
Fixes #3592