Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the sidebar namespaces hover effect at last-child #3562

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Fixed the sidebar namespaces hover effect at last-child #3562

merged 1 commit into from
Feb 4, 2019

Conversation

AVRahul
Copy link
Contributor

@AVRahul AVRahul commented Jan 18, 2019

Fixes #3555
Applied the hover effect to the last child to fix the other above sidebar nodes to remain constant and to improve experience through all the browsers.

Signed-off-by: A V RAHUL [email protected]

@dholbach dholbach requested a review from fbarl January 18, 2019 11:13
@dholbach dholbach added the component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer label Jan 18, 2019
@dholbach dholbach requested a review from foot January 18, 2019 12:05
@foot
Copy link
Contributor

foot commented Jan 21, 2019

Ah hah this stops the filters other than namespace from subtlety jumping around?

@AVRahul
Copy link
Contributor Author

AVRahul commented Jan 21, 2019

yes, it stops the other filters hovering in the sidebar.

Copy link
Contributor

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@bboreham bboreham merged commit d9a0232 into weaveworks:master Feb 4, 2019
@bboreham bboreham mentioned this pull request Feb 5, 2019
@AVRahul AVRahul deleted the fix/hover-sidebar branch June 4, 2019 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve namespace-filter expansion UX.
4 participants