Add X-Scope-Probe-ID header to POSTs #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbourgon
force-pushed
the
probe-id-header
branch
from
94c3713 to
f85b505
Compare
|
Would something like the hostname be more meaningful to the user? |
|
Hmm, I can't think of a normal scenario where the hostname wouldn't work... will make the change. |
peterbourgon
force-pushed
the
probe-id-header
branch
from
013d175 to
c06cbf2
Compare
| } | ||
|
|
||
| // ScopeProbeIDHeader is the header we use to carry the probe's unique ID. The | ||
| // ID is generated at runtime and has the same lifetime as the probe process. |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Fix comment, please, then LGTM |
peterbourgon
force-pushed
the
probe-id-header
branch
from
8f9edda to
43bfecb
Compare
|
Test failure seems to be GCE related. |
peterbourgon
added a commit
that referenced
this pull request
Aug 13, 2015
Add X-Scope-Probe-ID header to POSTs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @2opremio @paulbellamy