Move "hideous hack" for Kubernetes service network from probe to app #3432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids side-effects from reporting Kubernetes from a cluster-level probe, and removes a lie from the probe data. Rather than do the work every time the probe sends a report, we do it every time the app renders endpoints, which should be once per merged report set.
rade
approved these changes
Nov 19, 2018
Right, if the probe has already put the service route in then this should re-add it which is a no-op. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address an inconsistency introduced by #3274, reporting Kubernetes info from a cluster-level probe, and removes a lie from the probe data.
Suggested at #3428 (comment)
Rather than do the work every time the probe sends a report, we do it every time the app renders endpoints, which should be once per merged report set.
Replaces #3428