Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the CRI volumeMount name in the example manifest #3308

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

dlespiau
Copy link
Contributor

@dlespiau dlespiau commented Aug 8, 2018

volumeMounts need to refer to an existing volume name to be successfully
mounted. cri-socket is the defined volume name.

@dlespiau dlespiau requested a review from lilic August 8, 2018 13:30
Copy link
Contributor

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

volumeMounts need to refer to an existing volume name to be successfully
mounted. cri-socket is the defined volume name.
@dlespiau dlespiau force-pushed the 2018-08-08-fix-cri-socket-volume-name branch from 693f70a to 1a24894 Compare August 8, 2018 14:30
@bboreham bboreham merged commit 62a6838 into master Aug 8, 2018
@dlespiau dlespiau deleted the 2018-08-08-fix-cri-socket-volume-name branch August 8, 2018 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants