Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make header semitransparent #3294

Merged
merged 5 commits into from
Aug 3, 2018
Merged

Make header semitransparent #3294

merged 5 commits into from
Aug 3, 2018

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented Jul 31, 2018

Resolves #3285.

I initially tried to make only the children text elements (topology labels, etc..) semitransparent but didn't look that good so I thought it might be better to simply make the whole header strip more opaque to keep a stronger separation between the navigation elements and the content:

image

@fbarl fbarl self-assigned this Jul 31, 2018
@fbarl fbarl requested a review from bia July 31, 2018 14:14
Copy link
Contributor

@bia bia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea!
It does not totally resolve #3285 because of the filters in the bottom left, but maybe it's enough for now?

@fbarl fbarl force-pushed the 3285-increase-header-opacity branch from cd9d085 to c0a359b Compare August 2, 2018 09:14
@fbarl
Copy link
Contributor Author

fbarl commented Aug 2, 2018

@bia PTAL. I added the following changes:

  • Increased the filters' background opacity
  • Made all the active items in selectors more purple
  • Put Node Details panel one level on the top - I'm mainly asking for your approval on this part as things look a bit different now with the node details panel in focus (introduced by the first commit):

image

@bia
Copy link
Contributor

bia commented Aug 2, 2018

Made all the active items in selectors more purple

more purple helps a lot.

Why did you make it more opaque? Now it's barely noticeable that it's transparent. I would go back to how it was before.

Node details looks good!

@fbarl fbarl merged commit c33c91c into master Aug 3, 2018
@fbarl fbarl deleted the 3285-increase-header-opacity branch August 3, 2018 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants