Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new purple theme colors #3229

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Use new purple theme colors #3229

merged 1 commit into from
Jun 18, 2018

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented Jun 18, 2018

Scope part of weaveworks/ui-components#259.

Nothing noticable in the UI should have changed, only some CSS variable names are different.

Tested in Scope standalone.

@fbarl fbarl self-assigned this Jun 18, 2018
@fbarl fbarl requested a review from foot June 18, 2018 15:08
@fbarl fbarl changed the title Use new purple theme colors. Use new purple theme colors Jun 18, 2018
foot
foot approved these changes Jun 18, 2018
View reviewed changes
Copy link
Contributor

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, all seems to work fine w/ proxying etc. 👌 lgtm

@fbarl fbarl merged commit ed4ad46 into master Jun 18, 2018
@fbarl fbarl deleted the 259-new-purple-colors branch June 18, 2018 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foot foot foot approved these changes

Assignees

@fbarl fbarl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbarl @foot