Support controls in more k8s topologies #3110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rade
suggested changes
Mar 16, 2018
There was a problem hiding this comment.
There's one change I commented on that we should definitely make.
Other than that, the repetition is annoying. An alternative would be to perform a post-processing walk of the topologies that adds the report.ControlProbeID to all nodes. That could be used for the existing control-ful topologies - containers, pods - too. i.e. somewhere we could simply have a "list of topologies that should have controls".
The main downside would be the extra memory allocation required to perform the update. I suspect @bboreham won't let us do that ;)
Also, I was surprised to see no changes to tests.
probe/kubernetes/reporter.go
Outdated
| if err != nil { | ||
| return result, err | ||
| } | ||
| cronJobTopology, cronJobs, err := r.cronJobTopology() | ||
| cronJobTopology, cronJobs, err := r.cronJobTopology(r.probeID) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Controls for nodes generally need to know about the probe that is in control of them. This PR appends the probe ID info to k8s topologies CronJob, DaemonSet, Service, and StatefulSet. Therefore allowing plugins to append controls.
rndstr
force-pushed
the
3107-service-controls
branch
from
fc0b5de to
d3231c6
Compare
|
@rade PTAL |
rade
approved these changes
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability for more k8s topologies to have controls displayed in the frontend by plugins. Namely Service, DaemonSet, StatefulSet, Cronjob.
Fixes #3107