Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative positioning for Table view tables #3066

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented Feb 12, 2018

Follow-up on #3065 (which needs to be merged first).

Fixes #3015.

Use relative positioning for NodesGrid and calculate its height from its top coordinate + window height.

@fbarl fbarl self-assigned this Feb 12, 2018
@fbarl fbarl requested a review from foot February 12, 2018 12:37
Copy link
Contributor

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented.

@foot
Copy link
Contributor

foot commented Feb 12, 2018

oops wrong pr. will review this properly in a second.

Copy link
Contributor

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fbarl fbarl force-pushed the 3015-dynamic-table-height branch from 1e5efab to 89c3e33 Compare February 13, 2018 12:26
@fbarl fbarl merged commit 7f7d2d4 into master Feb 13, 2018
@fbarl fbarl deleted the 3015-dynamic-table-height branch February 13, 2018 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants