Move DNS name mapping from endpoint to report #3061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
force-pushed
the
dns-on-report
branch
from
1b2e83d to
0c88e43
Compare
rade
suggested changes
Feb 7, 2018
render/detailed/connections.go
Outdated
| @@ -73,7 +73,7 @@ func newConnectionCounters() *connectionCounters { | |||
| return &connectionCounters{counted: map[string]struct{}{}, counts: map[connection]int{}} | |||
| } | |||
|
|
|||
| func (c *connectionCounters) add(outgoing bool, localNode, remoteNode, localEndpoint, remoteEndpoint report.Node) { | |||
| func (c *connectionCounters) add(rpt report.Report, outgoing bool, localNode, remoteNode, localEndpoint, remoteEndpoint report.Node) { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
report/report.go
Outdated
| @@ -469,6 +475,37 @@ func (r Report) upgradeNamespaces() Report { | |||
| return r | |||
| } | |||
|
|
|||
| // Note in-place modification of Endpoint.Nodes | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
report/report.go
Outdated
| reverseNames, foundR := endpoint.Sets.Lookup(ReverseDNSNames) | ||
| if ok && (foundS || foundR) { | ||
| // Add address and names to report-level data - we assume | ||
| // all endpoints with the same address have equally good data |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
bboreham
force-pushed
the
dns-on-report
branch
from
4116e73 to
f26030a
Compare
|
I made the requested changes and rebased. Also moved |
rade
approved these changes
Feb 20, 2018
bboreham
force-pushed
the
dns-on-report
branch
from
f26030a to
b5cdcb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3058
If the probe sees many TCP sockets on a host, it will repeat the same address information on each endpoint. Moving it to report level saves all this repetition. Also
Setsis an expensive data structure; for the DNS mapping I used a straightforwardmap, similar toTopology.Nodes.I see about a 6% reduction in JSON file size, on Weave Cloud production reports.
The mapping is used as a mapping from IP address to name, and the current implementation encodes it the same way, but to me it seems more logical to send it as a mapping from name to address. Probably that doesn't matter.
I considered movingDNSFirstMatchfromrendertoreport, to collect all the behaviour together. However the decisions made are somewhat related to rendering, so I left it.