Remove default values from URL state hash #3030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarl
force-pushed
the
1727-remove-default-values-from-url-hash
branch
from
74093d4 to
0de0a9a
Compare
fbarl
changed the title
foot
approved these changes
Jan 22, 2018
| @@ -661,7 +658,7 @@ export function rootReducer(state = initialState, action) { | |||
| state = setTopology(state, state.get('currentTopologyId')); | |||
| // only set on first load, if options are not already set via route | |||
| if (!state.get('topologiesLoaded') && state.get('topologyOptions').size === 0) { | |||
| state = setDefaultTopologyOptions(state, state.get('topologies')); | |||
| state = state.set('topologyOptions', getDefaultTopologyOptions(state)); | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This is not an ideal argument against it, but that change would make it possible to have an empty state hash (if we're on all defaults), which would be tricky to distinguish from no state at all which would default to localStorage. Something to consider in a future PR perhaps, but I think we can make a small exception with |
fbarl
force-pushed
the
1727-remove-default-values-from-url-hash
branch
from
7316b75 to
0176536
Compare
fbarl
force-pushed
the
1727-remove-default-values-from-url-hash
branch
from
0176536 to
7e729dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1727.
Changes
major
topologyOptionsin Scope state. These are calculated via new helperhashDifferenceDeepwhich basically omits all the deep non-hash values which correspond literally to default options.minor
labelfield fromnodeDetailsScope state hash array, as it wasn't used anywhere.searchQueryRedux state default to''for better matching with the URL state.Note: I'm aware that
topologyIdfield could also have been omitted in the URL in case it has a default value, but that default topology is somewhat arbitrary and I didn't want to make a special case of it.