cheap probe connectedness api endpoint #2983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...so we can recycle the former name.
This makes Report() more readable. We also intend to use this function elsewhere.
This requires no report reading / merging. We plan to expose this in the HTTP API, so the UI gets a cheap way of checking whether the app is currently receiving data from probes.
In many cases we only need to know whether there are _any_ connected probes, and not the probe details. Obtaining that info is cheaper since it requires no reading or merging or reports.
leth
reviewed
Dec 14, 2017
| if err != nil { | ||
| respondWith(w, http.StatusInternalServerError, err) | ||
| } | ||
| respondWith(w, http.StatusOK, hasProbes) |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
rade
added a commit
to weaveworks/service
that referenced
this pull request
Dec 14, 2017
The UI needs to get hold of the service status _a lot_ and most of the time only cares about "is it connected or not" rather than counts of probes, etc. As of weaveworks/scope#2983, the former is a lot cheaper to obtain than the latter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduce a cheap
/api/probes?sparsevariant.In many cases we only need to know whether there are any connected probes, and not the probe details. Obtaining that info is cheaper since it requires no reading or merging or reports.
Fixes #2982.