In Docker, {app,probe} -> {scope-app,scope-probe} #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, yeah: addresses #286 |
| @@ -17,7 +17,8 @@ all: $(SCOPE_EXPORT) | |||
|
|
|||
| $(SCOPE_EXPORT): $(APP_EXE) $(PROBE_EXE) docker/* | |||
| @if [ -z '$(DOCKER_SQUASH)' ]; then echo "Please install docker-squash by running 'make deps'." && exit 1; fi | |||
| cp $(APP_EXE) $(PROBE_EXE) docker/ | |||
| cp $(APP_EXE) docker/scope-app | |||
| cp $(PROBE_EXE) docker/scope-probe | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Is it important this goes in before release? |
peterbourgon
force-pushed
the
rename-components
branch
from
40a25ec to
ea9eaae
Compare
|
No. |
|
LGTM; fine with approach. I'd hold off until after release, although up to you. |
|
Happy to hold off. |
|
We're post-release now. |
peterbourgon
added a commit
that referenced
this pull request
Jul 2, 2015
In Docker, {app,probe} -> {scope-app,scope-probe}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A "more correct" way of doing this would be renaming the app and probe directories to scope-app and scope-probe, but that makes importing the packages under probe very ugly. I think this strikes a reasonable balance: when doing the blessed build via
make, we produce special scope-app and scope-probe binaries, and reference them in the various Docker scripts.LMKWYT.