Fix host on darwin #289
Merged
Fix host on darwin #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbourgon
force-pushed
the
fix-host-on-darwin
branch
from
b6668b5 to
a3defba
Compare
| @@ -37,7 +37,8 @@ test: | |||
| - cd $SRCDIR; ./bin/lint . | |||
| - cd $SRCDIR; make client-test | |||
| - cd $SRCDIR; make static | |||
| - cd $SRCDIR; make | |||
| - cd $SRCDIR; rm -f app/app probe/probe; GOOS=linux make | |||
| - cd $SRCDIR; rm -f app/app probe/probe; GOOS=darwin make | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
LGTM with squash |
Also, add explicit GOOS=darwin target for circle.
peterbourgon
force-pushed
the
fix-host-on-darwin
branch
from
7d8660a to
36212ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if Circle will work...