-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flat background instead of gradient #2886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
Please just remove the first commit Merge branch 'master' into background-colors before merging (we normally do git fetch && git rebase origin/master
in the working branch when we want to pull the latest changes from master) and check out my comment about overlay wrapper transparency.
@@ -58,5 +58,5 @@ $search-border-width: 1px; | |||
$timeline-height: 55px; | |||
|
|||
/* specific elements */ | |||
$body-background-color: linear-gradient(30deg, $background-color 0%, $background-lighter-color 100%); | |||
$body-background-color: $background-average-color; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
client/app/styles/_base.scss
Outdated
@@ -102,7 +102,7 @@ a { | |||
|
|||
.overlay-wrapper { | |||
align-items: center; | |||
background-color: fade-out($background-average-color, 0.1); | |||
background-color: transparent; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Thanks for the comments! The overlay background colour makes sense and I reverted the transparent colour change. How do I remove Merge branch 'master' into background-colors? |
I'm not sure how @rndstr's command works, but If you don't manage to fix your git tree for this PR, maybe you could just reset your branch at master and apply that one line change in a new clean commit (normally I wouldn't recommend that but this PR is really just a one-liner). Hope that helps! :) |
Thanks @fbarl ! That's fixed now. |
That appends |
As decided in last week's design sync.
@fbarl was there another reason why the overlay-wrapper would need a background colour? I remember talking about it...