Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Node 8.4 for builds #2830

Merged
merged 1 commit into from
Aug 22, 2017
Merged

Use Node 8.4 for builds #2830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions client/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
FROM node:6.9.0
RUN npm install -g yarn

This comment was marked as abuse.

Sign in to view

FROM node:8.4.0
WORKDIR /home/weave
COPY package.json yarn.lock /home/weave/
ENV NPM_CONFIG_LOGLEVEL=warn NPM_CONFIG_PROGRESS=false
Expand Down
4 changes: 2 additions & 2 deletions client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"reqwest": "2.0.5",
"reselect": "3.0.0",
"reselect-map": "1.0.1",
"weaveworks-ui-components": "git+https://github.com/weaveworks/ui-components.git#v0.1.20",
"weaveworks-ui-components": "git+https://github.com/weaveworks/ui-components.git#v0.1.28",
"whatwg-fetch": "2.0.3",
"xterm": "2.5.0"
},
Expand Down Expand Up @@ -128,6 +128,6 @@
]
},
"engines": {
"node": "^6.9.0"
"node": "^8.4.0"

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

}
}
6 changes: 3 additions & 3 deletions client/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6207,9 +6207,9 @@ wd@^0.4.0:
underscore.string "~3.0.3"
vargs "~0.1.0"

"weaveworks-ui-components@git+https://github.com/weaveworks/ui-components.git#v0.1.20":
version "0.1.20"
resolved "git+https://github.com/weaveworks/ui-components.git#46e6165f39defe8a720b59a9db69c93514960e00"
"weaveworks-ui-components@git+https://github.com/weaveworks/ui-components.git#v0.1.28":
version "0.1.28"
resolved "git+https://github.com/weaveworks/ui-components.git#164a0d2770ee5c2318b2f1ab1948fb6046059909"
dependencies:
babel-cli "^6.18.0"
babel-plugin-transform-export-extensions "6.8.0"
Expand Down