Time Travel: unmount in the shutdown() action #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, without any context, but still has the [WIP] tag. |
fbarl
force-pushed
the
dont-resume-time-when-timeline-unmounted
branch
from
d58dab2 to
0c78962
Compare
fbarl
changed the title
|
@jpellizzari PTAL
I think the first commit accidentaly solved the case described in the referenced issue, but you'd still get the same bug if you tried clicking on Time Travel before switching to Monitor - now that part has been fixed as well. p.s. the branch name is still a bit of a misnomer :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/weaveworks/service-ui/issues/814 by making timeline deconstruction part of the
shutdown()action, avoiding the attempt to establish new connections.Also, triggering
resumeTimeaction only if previously paused.